Support for non-string column names in st.data_editor
#7485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
reviewed
Oct 4, 2023
LukasMasuch
changed the title
st.data_editorst.data_editor
vdonato
approved these changes
Oct 4, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
* Fix non-string column names with data editor * Fix test * Apply additional fixes * Change back * Put into function * Fix stringifying headers * Migrate data editor input data test to playwright * Update snapshots * Add unit test to check column names * Clean test script
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
* Fix non-string column names with data editor * Fix test * Apply additional fixes * Change back * Put into function * Fix stringifying headers * Migrate data editor input data test to playwright * Update snapshots * Add unit test to check column names * Clean test script
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Fix non-string column names with data editor * Fix test * Apply additional fixes * Change back * Put into function * Fix stringifying headers * Migrate data editor input data test to playwright * Update snapshots * Add unit test to check column names * Clean test script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Support non-string column names in
st.data_editorby automatically converting them tostring.This PR also migrates the
st_data_editor_input_data.pye2e test to playwright.GitHub Issue Link (if applicable)
st.data_editorvalues whose column names are int/float leads toKeyError: 'colname' #6950Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.