Fix Chat Message container to align and manage the autosizer handling #7504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhuang1997
approved these changes
Oct 9, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
…streamlit#7504) * Fix Chat Message container to align and manage the autosizer handling * Remove chat message snapshots * Add Updated Snapshots * Attempt to make new playwright test * Remove async def as it's not supported * Add new snapshots * Minor cleanup --------- Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
…streamlit#7504) * Fix Chat Message container to align and manage the autosizer handling * Remove chat message snapshots * Add Updated Snapshots * Attempt to make new playwright test * Remove async def as it's not supported * Add new snapshots * Minor cleanup --------- Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…streamlit#7504) * Fix Chat Message container to align and manage the autosizer handling * Remove chat message snapshots * Add Updated Snapshots * Attempt to make new playwright test * Remove async def as it's not supported * Add new snapshots * Minor cleanup --------- Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removing the autosizer caused some issues on the chat message this is due to two things:
flex-shrinkto 0 (it looks like (1) resolves the issue cause the message content doesn't unnecessarily grow, but it's good to inform the browser).GitHub Issue Link (if applicable)
#7473
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.