Support Graphviz layout engines #7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
reviewed
Oct 5, 2023
LukasMasuch
reviewed
Oct 5, 2023
LukasMasuch
approved these changes
Oct 5, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
* Support Graphviz layout engines * Ensure radio option and engine match in test * Update unit test * Update snapshots * Update comment in proto to remove 'Dot language' * Update offending snapshot * Delete all chromium snapshots and regenerate * Add missing chromium snapshots * Reintroduce 'Dot language' comment in proto * Call engine in jest.mock * Use default renderer when provided only spec as string * Test if chart renders when input is a dot string * Delete obsolete e2e test * Upload last remaining snapshots
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
* Support Graphviz layout engines * Ensure radio option and engine match in test * Update unit test * Update snapshots * Update comment in proto to remove 'Dot language' * Update offending snapshot * Delete all chromium snapshots and regenerate * Add missing chromium snapshots * Reintroduce 'Dot language' comment in proto * Call engine in jest.mock * Use default renderer when provided only spec as string * Test if chart renders when input is a dot string * Delete obsolete e2e test * Upload last remaining snapshots
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Support Graphviz layout engines * Ensure radio option and engine match in test * Update unit test * Update snapshots * Update comment in proto to remove 'Dot language' * Update offending snapshot * Delete all chromium snapshots and regenerate * Add missing chromium snapshots * Reintroduce 'Dot language' comment in proto * Call engine in jest.mock * Use default renderer when provided only spec as string * Test if chart renders when input is a dot string * Delete obsolete e2e test * Upload last remaining snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The Graphviz renderer used on the frontend (d3-graphviz v2.6.1) supports different layout engines: dot (default), neato, twopi, circo, fdp, osage, patchwork. Streamlit uses the default “dot” engine. When users specify any other engine, we ignore their choice. This PR makes Streamlit respect the choice of engine users provide in
st.graphviz_chart.To do so we:
GraphVizChartprotobuf messages support the specification of an engineGraphVizChartcomponent before calling.renderDotGitHub Issue Link (if applicable)
Closes #4089.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.