Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send message to parent #7522

Merged
merged 6 commits into from Oct 18, 2023
Merged

Send message to parent #7522

merged 6 commits into from Oct 18, 2023

Conversation

mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Oct 6, 2023 •
edited

Describe your changes

Extension of host configuration endpoint (PR link) - setting to enable/disable custom string messages from app to host

Testing Plan

  • Unit Tests (JS and/or Python) ✅
  • Manually tested ✅

Resources:

  • Product Spec
  • Tech Spec
  • Risk Assessment PR ✅
  • Threat Model PR ✅

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 6, 2023
View reviewed changes
lib/streamlit/platform.py Fixed Show fixed Hide fixed
@mayagbarnes mayagbarnes marked this pull request as ready for review October 16, 2023 18:37
@mayagbarnes mayagbarnes changed the title [WIP] Send message to parent Send message to parent Oct 16, 2023
LukasMasuch
LukasMasuch approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 One more test for the enabled state would be good

frontend/app/src/App.test.tsx Outdated Show resolved Hide resolved
frontend/app/src/App.test.tsx Show resolved Hide resolved
@mayagbarnes mayagbarnes merged commit ec2eb2b into develop Oct 18, 2023
47 of 48 checks passed
@mayagbarnes mayagbarnes deleted the parent-messages branch October 18, 2023 21:08
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
@mayagbarnes @eric-skydio
Send message to parent (streamlit#7522)
083148b 
Extension of host configuration endpoint - setting to enable/disable custom string messages from app to host
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
@mayagbarnes
Send message to parent (streamlit#7522)
942f752 
Extension of host configuration endpoint - setting to enable/disable custom string messages from app to host
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
@mayagbarnes @zyxue
Send message to parent (streamlit#7522)
4a804aa 
Extension of host configuration endpoint - setting to enable/disable custom string messages from app to host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasMasuch LukasMasuch LukasMasuch approved these changes

@vdonato vdonato Awaiting requested review from vdonato

@sfc-gh-mnowotka sfc-gh-mnowotka Awaiting requested review from sfc-gh-mnowotka

Assignees
No one assigned
Labels
change:refactor impact:internal security-assessment-completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayagbarnes @LukasMasuch