Improved AppTest/ElementTree formatting #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vdonato
approved these changes
Nov 2, 2023
Comment on lines
1567
to
1578
| defaults: list[Any] = [None, "", False, [], set(), dict()] | ||
|
|
||
| if dataclasses.is_dataclass(self): | ||
| fields_vals = ( | ||
| (f.name, getattr(self, f.name)) | ||
| for f in dataclasses.fields(self) | ||
| if f.repr | ||
| and getattr(self, f.name) != f.default | ||
| and getattr(self, f.name) not in defaults | ||
| ) | ||
| else: | ||
| fields_vals = ((f, v) for (f, v) in self.__dict__.items() if v not in defaults) |
There was a problem hiding this comment.
nit: might be worth adding a comment above defaults mentioning that empty lists/sets/dicts compare to be equal -- I thought this wouldn't work when first reading through this before double checking that they do
|
@AnOctopus mind posting an output (copy/paste or screenshot) about how this looks? Exciting! 🚀 |
|
|
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Make AppTest and ElementTree reprs into an indented tree format, to aid debugging
GitHub Issue Link (if applicable)
Testing Plan
Manually tested, difficult to write reasonable tests for.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.