[WIP] Query Params #7664
Closed
[WIP] Query Params #7664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…QueryParam class (#7621) * Add clear, clear, __delitem__, __len__, __contains__, __init__ methods with tests --------- Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
* Remove unnecessary method as I realize the internal state of query params will not need to use this method * Fix e2e test * Fix python tests
|
I initially thought this wouldn't require any security process since we're not changing anything about how query params are sent over the wire, but given that #7619 would have introduced a vulnerability where users would be able to see query params set by other sessions, we should probably go through the full process for this to be safe. |
|
Closing this as I would like to create a new branch as we have come to the conclusion that we likely don't want a separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.