-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QueryParamsProxy to streamlit api #7772
Merged
willhuang1997
merged 71 commits into
feature/st_query_params_2
from
feature/add_query_params_st_api
Nov 30, 2023
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
c916991
Add query params class as it doesn't seem like session state internal…
willhuang1997 93739c9
Add query params to session_state
willhuang1997 9f29c94
Add QueryParamsProxy with tests
willhuang1997 019e2dc
Add st.query_params to api
willhuang1997 6d32245
Add test fixes and add query params to state folder's init
willhuang1997 bb95ee0
Revert init py as I should add it to another PR
willhuang1997 3d25628
Add New Classes to state's init
willhuang1997 f6db72a
Fix typing errors
willhuang1997 07fe0c4
Add no deadline setting as copying takes longer now
willhuang1997 9d156f1
Fix tests and remove the parameter in init
willhuang1997 048e221
Merge branch 'feature/session_state_query_params' into feature/QueryP…
willhuang1997 ab85db0
Move init declarations around to be consistent
willhuang1997 578a593
Minor nit fix
willhuang1997 990d2c4
Add doc string for now. it can change
willhuang1997 8339c64
Move QueryParamsProxy to its own class
willhuang1997 e24bee3
Move import around
willhuang1997 596e05b
Merge branch 'feature/QueryParamsProxy' into feature/add_query_params…
willhuang1997 a359377
Fix typing errors
willhuang1997 f6da4e2
Add to_dict to query_params_proxy
willhuang1997 a5a60c3
Fix typing error
willhuang1997 1381bc6
Fix typing error
willhuang1997 8ca2b94
Remove mutable mapping to get rid of type ignores
willhuang1997 971e27f
Remove part of comment
willhuang1997 461e445
Merge branch 'feature/QueryParamsProxy' into feature/add_query_params…
willhuang1997 c93ec1a
Add test for write.py
willhuang1997 d3f622e
Move query_params in commands folder to experimental_query_params.py
willhuang1997 f9c8e86
Merge branch 'feature/session_state_query_params' into feature/QueryP…
willhuang1997 5835aee
Merge branch 'feature/QueryParamsProxy' into feature/add_query_params…
willhuang1997 6a63fd4
Add embed exception tests]
willhuang1997 1174338
Merge branch 'feature/session_state_query_params' into feature/QueryP…
willhuang1997 9273f14
Merge branch 'feature/QueryParamsProxy' into feature/add_query_params…
willhuang1997 9e483cb
Adjust for comments and also change query_params_test in commands fol…
willhuang1997 59212c7
Fix typing error
willhuang1997 109d012
Fix names of tests
willhuang1997 7db65d1
Change query_param variable name to d
willhuang1997 660dcfb
Fix test as I refactored some code
willhuang1997 b4e01a5
Fix comment
willhuang1997 f5c1477
Address comments
willhuang1997 fe3e40c
Fix typing errors and remove unused imports
willhuang1997 fb60587
Fix threading problem as we should make sure we lock
willhuang1997 9c640ba
Fix typing errors
willhuang1997 2d47695
Merge branch 'feature/session_state_query_params' into feature/QueryP…
willhuang1997 fb2bd42
Minor fixes with typing
willhuang1997 fcdc169
Merge branch 'feature/QueryParamsProxy' into feature/add_query_params…
willhuang1997 14b7eb7
Remove underscore from query params
willhuang1997 8f5bc1e
Fix typing mistakes, remove unnecessary methods, and fix comments
willhuang1997 24228b0
Remove unnecessary tests and fix function definitions of tests
willhuang1997 9c57c14
Fix test function name
willhuang1997 c413887
Fix comment
willhuang1997 b3084d3
Attempt to make comments better
willhuang1997 2378b8a
Merge branch 'feature/session_state_query_params' into feature/QueryP…
willhuang1997 bdfce4a
Minor fixes to comments and tests
willhuang1997 e2f9963
Remove attr methods as that causes a lot of hackiness
willhuang1997 1f909ae
Modify test as we used a hack
willhuang1997 7bce541
Add comments for get item
willhuang1997 4d2a491
Fix to_dict to only contain last element
willhuang1997 5a878e0
Merge branch 'feature/session_state_query_params' into feature/QueryP…
willhuang1997 88ad341
Fix threading problem and add tests
willhuang1997 ec15178
Fix typing problems
willhuang1997 ba5c0bc
Fix typing for contextmanager method
willhuang1997 ce2f7d9
Merge branch 'feature/QueryParamsProxy' into feature/add_query_params…
willhuang1997 18c75e1
Add comment
willhuang1997 f51692d
Merge branch 'develop' into feature/session_state_query_params
willhuang1997 359ee6e
fix comments
willhuang1997 385b14a
Address comments
willhuang1997 3572673
Merge branch 'feature/session_state_query_params' into feature/QueryP…
willhuang1997 6529f30
address comments
willhuang1997 9090315
Merge branch 'feature/st_query_params_2' into feature/QueryParamsProxy
willhuang1997 b52d85a
Change import as i forgot to commit this file
willhuang1997 ad5b692
Merge branch 'feature/QueryParamsProxy' into feature/add_query_params…
willhuang1997 dfc3172
Merge branch 'feature/st_query_params_2' into feature/add_query_param…
willhuang1997 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we mimick the
to_dict
method as Flask provides it?For
flat=True
it would do what it currently does. Forflat=False
it would make a list for every key, regardless of whether it's only one value. I like this because if theflat
parameter is not available the user ofto_dict
will have to do a lot ofisinstance
checking.Or is there already a different way of predictably getting a list of values (even if there is only one value)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be solved with
get_all()
support.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll check it out