Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix st.toggle background color #7788

Merged
merged 3 commits into from Dec 1, 2023
Merged

Fix st.toggle background color #7788

merged 3 commits into from Dec 1, 2023

Conversation

sfc-gh-jgarcia
Copy link
Contributor

@sfc-gh-jgarcia sfc-gh-jgarcia commented Nov 30, 2023

Describe your changes

This PR makes a small change to our st.toggle component, making its background color when it's not on the same as the outline we use for st.radio and st.checkbox

Before:

CleanShot 2023-11-13 at 17 33 33

After:

Screenshot 2023-11-30 at 1 40 16 PM

Screenshot 2023-11-30 at 1 40 22 PM

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed: Tests are already in place
  • Unit Tests (JS and/or Python): No change
  • E2E Tests: Updated
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-jgarcia sfc-gh-jgarcia changed the title Fix toggle color Fix st.toggle background color Nov 30, 2023
@sfc-gh-jgarcia sfc-gh-jgarcia marked this pull request as ready for review November 30, 2023 18:05
@vdonato vdonato merged commit 09a0d58 into develop Dec 1, 2023
44 checks passed
@vdonato vdonato deleted the fix-toggle-color branch December 1, 2023 08:40
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
* Update background color for toggle, to match radio and checkboxes

* Regenerate toggle snapshots

* Add back regenerated snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants