Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent hiding required editable columns #7888

Merged
merged 1 commit into from Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -359,6 +359,28 @@ describe("useColumnLoader hook", () => {
}
})

it("disallows hidden for editable columns that are required", () => {
const element = ArrowProto.create({
data: UNICODE,
editingMode: ArrowProto.EditingMode.DYNAMIC,
columns: JSON.stringify({
c1: {
required: true,
hidden: true,
},
}),
})

const data = new Quiver(element)

const { result } = renderHook(() => {
return useColumnLoader(element, data, false)
})

expect(result.current.columns[1].isRequired).toBe(true)
expect(result.current.columns[1].isHidden).toBe(false)
})

it("doesn't configure any icon for non-editable columns", () => {
const element = ArrowProto.create({
data: UNICODE,
Expand Down
Expand Up @@ -262,6 +262,14 @@ function useColumnLoader(
...updatedColumn,
icon: "editable",
}

// Make sure that required columns are not hidden:
if (updatedColumn.isRequired) {
updatedColumn = {
...updatedColumn,
isHidden: false,
}
}
}

return ColumnType(updatedColumn)
Expand Down