Use commonpath rather than common prefix for more secure access #7901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
commented
Jan 4, 2024
| @@ -21,7 +21,7 @@ | |||
| from streamlit.web.server import ComponentRequestHandler | |||
|
|
|||
| URL = "http://not.a.real.url:3001" | |||
| PATH = "not/a/real/path" | |||
There was a problem hiding this comment.
commonpath will error if comparing absolute and relative paths. Both paths will always be relative, so I want the path in the test to be absolute.
kajarenc
approved these changes
Jan 5, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…amlit#7901) * Use commonpath rather than common prefix for more secure access * Update Static File Handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We created a change that ensures users cannot access file contents outside of custom components folders which leverages
os.path.commonprefix. This works great except in the event where there exists a folder that share a same prefix (/foo/bar/bazand/foo/bar/baz_qux).commonpathensures we the path is the exact same.GitHub Issue Link (if applicable)
Testing Plan
There's a unit test that covers this specific use case.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.