Make Snowpark dependency truly optional for SnowflakeConnection #7919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
force-pushed
the
vdonato/snowpark-import-fix
branch
from
4f7e565
to
c8c2557
Compare
vdonato
commented
Jan 9, 2024
| @@ -48,6 +47,14 @@ def test_not_running_in_sis(self): | |||
| def test_running_in_sis(self): | |||
| assert running_in_sis() | |||
|
|
|||
| @pytest.mark.require_snowflake | |||
There was a problem hiding this comment.
Having to do this is mildly unfortunate, but we can't mock snowflake.* without having snowflake-connector-python installed. In reality, having either the snowflake or snowpark libraries not installed will result in a ModuleNotFoundError being thrown.
AnOctopus
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug in
SnowflakeConnectionwhere we attempt to importsnowflake.snowparkonconnect, which blows up when
snowflake-snowpark-python, which should be optional for use of thisconnection, isn't installed. This PR fixes this by moving some imports and handling
ModuleNotFoundErrorsin the
running_in_sishelper function.