Allow custom themes to override embed options query parameter #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
kmcgrady
force-pushed
the
fix/custom-theme
branch
from
51dd8ee
to
764b3c3
Compare
kmcgrady
force-pushed
the
fix/custom-theme
branch
from
5d989cc
to
9f757b0
Compare
kmcgrady
commented
Mar 12, 2024
There was a problem hiding this comment.
I can't explain how this changed, but the tests fail consistently. It's possible the dark theme was being set at the end of script run which was creating some very subtle change. In that case, updating the screenshot makes sense.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…lit#8021) ## Describe your changes We set the theme based on the query param each time the script run is finished. This can break other theme settings, so we want to respect the query parameters only on initial load (in determining the default theme. ## GitHub Issue Link (if applicable) Closes streamlit#7118 ## Testing Plan - Updated JS Unit Tests for the default theme. There were no tests for the script finished action, so I did not include tests for the removal. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We set the theme based on the query param each time the script run is finished. This can break other theme settings, so we want to respect the query parameters only on initial load (in determining the default theme.
GitHub Issue Link (if applicable)
Closes #7118
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.