Fix custom dataframe scrollbars in Chrome #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
LGTM, thanks for fixing! A small nit: I think it would be beneficial to slightly extend the comment at for StyledResizableContainer here, explaining a little what is done there. For example, as far as I understand the last part ...(!hasCustomizedScrollbars && { scrollbarWidth: "thin" }) is only required for Firefox.
kmcgrady
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Fix custom dataframe scrollbars in Chrome and Safari * Add comment
kmcgrady
added a commit
that referenced
this pull request
Feb 1, 2024
* Up version to 1.31.0 * Fix custom dataframe scrollbars in Chrome (#8034) * Fix custom dataframe scrollbars in Chrome and Safari * Add comment --------- Co-authored-by: Lukas Masuch <Lukas.Masuch@gmail.com>
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Fix custom dataframe scrollbars in Chrome and Safari * Add comment
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Up version to 1.31.0 * Fix custom dataframe scrollbars in Chrome (streamlit#8034) * Fix custom dataframe scrollbars in Chrome and Safari * Add comment --------- Co-authored-by: Lukas Masuch <Lukas.Masuch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The latest Chrome update messed up our dataframe scrollbars once again. Apparently, applying the
scrollbarWidth: "thin"we applied in CSS properties will now cause our custom scrollbars to not be used:This PR fixes this by only applying the CSS property for browsers that don't use our customized scrollbars (e.g. Firefox).
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.