Fix: st.page_link URL preview shows file path
#8086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
commented
Feb 6, 2024
| @@ -682,7 +682,7 @@ def _page_link( | |||
| if label is None: | |||
| page_link_proto.label = page_name | |||
| page_link_proto.page_script_hash = page_data["page_script_hash"] | |||
| page_link_proto.page = full_path | |||
There was a problem hiding this comment.
page is fed to the href attribute in PageLink.tsx - this is what shows in the browser preview in the bottom left corner.
vdonato
approved these changes
Feb 8, 2024
kmcgrady
pushed a commit
that referenced
this pull request
Feb 8, 2024
Fix href setting for page links and update error message on invalid pages
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Fix href setting for page links and update error message on invalid pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix href setting for page links
GitHub Issue Link (if applicable)
Closes #8080