Fix issue using a local path with st.image on windows.
#8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
requested review from
vdonato,
AnOctopus and
kmcgrady
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AnOctopus
approved these changes
Feb 6, 2024
7 tasks
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
) ## Describe your changes This PR fixes an issue with using image files via a local path on Windows (streamlit#7271). This also unifies all URL checks in the Streamlit server with a Python native implementation and cuts out the `validators` dependency. ## GitHub Issue Link (if applicable) - Closes streamlit#7271 ## Testing Plan - Updated tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes an issue with using image files via a local path on Windows (#7271). This also unifies all URL checks in the Streamlit server with a Python native implementation and cuts out the
validatorsdependency.GitHub Issue Link (if applicable)
st.image()doesn't work with absolute local file-paths on Windows #7271Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.