Fix script runner stack overflow #8100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
approved these changes
Feb 8, 2024
LukasMasuch
reviewed
Feb 8, 2024
| pages.values(), | ||
| ), | ||
| None, | ||
| while True: |
There was a problem hiding this comment.
nit: maybe a comment here would be nice why we need/use a while True loop here.
|
Yep, it's just |
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
## Describe your changes Convert script runner handling of rerun requests to use a while loop instead of recursion, to fix a stack overflow for scripts that infinitely rerun themselves. ## GitHub Issue Link (if applicable) Brought up in streamlit#7768 ## Testing Plan It could probably be tested with `threading.excepthook` but I'm not sure that adds very much. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Convert script runner handling of rerun requests to use a while loop instead of recursion, to fix a stack overflow for scripts that infinitely rerun themselves.
GitHub Issue Link (if applicable)
Brought up in #7768
Testing Plan
It could probably be tested with
threading.excepthookbut I'm not sure that adds very much.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.