Normalize main script path in st.switch_page and st.page_link
#8103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-kjavadyan
changed the title
st.switch_page and st.page_link
kmcgrady
reviewed
Feb 7, 2024
| @@ -139,6 +139,7 @@ def switch_page(page: str) -> NoReturn: # type: ignore[misc] | |||
| raise NoSessionContext() | |||
|
|
|||
| main_script_path = os.path.join(os.getcwd(), ctx.main_script_path) | |||
| main_script_path = os.path.normpath(main_script_path) | |||
There was a problem hiding this comment.
Just throwing a couple thoughts to consider before merging.
- The problem is the script path is not our desired state, shouldn't we just do
os.path.normpath(ctx.main_script_path)instead of normpath the whole thing? I guess it's the same outcome, but perhaps we are specifically identifying the problem. - Should we actually be normalizing this at the very beginning on load, so that we can assume the main script path is set correctly (and avoid this issue again).
There was a problem hiding this comment.
Yep, I also thinking about this (normalizing main_script_path in context, and not on individual elements level, although here tried to keep changes as small as possible for the fix to not break something else unintentionally).
Absolutely agree it is worth doing!
I am happy to volunteer for that, just want to do it after this merge more carefully to potential side effects.
There was a problem hiding this comment.
I agree. I think I would do (1) narrow this more to the specific issue (the fact that the ctx.main_script_path needs to be normpath).
We can then consider expanding to my question for (2)
LukasMasuch
approved these changes
Feb 7, 2024
kmcgrady
pushed a commit
that referenced
this pull request
Feb 8, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Normalize the main path before using it in
st.page_linkandst.switch_page.Close: #8070
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.