Lazy-load emoji module to improve performance #8109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
changed the title
LukasMasuch
changed the title
LukasMasuch
changed the title
kajarenc
approved these changes
Feb 8, 2024
kajarenc
reviewed
Feb 8, 2024
| @@ -40,14 +36,29 @@ def clean_text(text: "SupportsStr") -> str: | |||
| return textwrap.dedent(str(text)).strip() | |||
|
|
|||
|
|
|||
| def _contains_special_chars(text: str) -> bool: | |||
There was a problem hiding this comment.
@LukasMasuch If I understand correctly this code, this method could be replaced with python built-in
str.isalnum method
7 tasks
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
## Describe your changes The emoji data is the biggest object when running a blank Streamlit app. Compiling the regex is also slightly expensive. However, the emoji data is only required if there is a check for emojis; many apps might not require this. Therefore, this PR makes the emoji module to lazy load only if it is actually required. This also adds a precheck for emoji checks to make sure that the string even contains non alphanumeric characters before using the more expensive emoji regex. ## GitHub Issue Link (if applicable) Related to streamlit#6066 ## Testing Plan - Added e2e test to check that some lazy-loaded modules are not imported in an almost blank Streamlit app. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The emoji data is the biggest object when running a blank Streamlit app. Compiling the regex is also slightly expensive. However, the emoji data is only required if there is a check for emojis; many apps might not require this. Therefore, this PR makes the emoji module to lazy load only if it is actually required.
This also adds a precheck for emoji checks to make sure that the string even contains non alphanumeric characters before using the more expensive emoji regex.
GitHub Issue Link (if applicable)
Related to #6066
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.