Lazy-load the watchdog event watcher module #8111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LukasMasuch
changed the title
LukasMasuch
changed the title
LukasMasuch
changed the title
AnOctopus
approved these changes
Feb 8, 2024
7 tasks
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
## Describe your changes If a user configures `server.fileWatcherType` to none or poll, there isn't any reason we need to import the watchdog package, even if it is installed on the system. This PR applies a couple of small refactorings to make the `event_based_path_watcher` lazy-loaded (only importer if actually needed). ## GitHub Issue Link (if applicable) Related to streamlit#6066 ## Testing Plan - Added e2e test to make sure that `watchdog` and `streamlit.watcher.event_based_path_watcher` are lazy loaded. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If a user configures
server.fileWatcherTypeto none or poll, there isn't any reason we need to import the watchdog package, even if it is installed on the system. This PR applies a couple of small refactorings to make theevent_based_path_watcherlazy-loaded (only importer if actually needed).GitHub Issue Link (if applicable)
Related to #6066
Testing Plan
watchdogandstreamlit.watcher.event_based_path_watcherare lazy loaded.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.