Lazy-load pandas and pyarrow to improve performance #8125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
changed the title
7 tasks
kajarenc
reviewed
Feb 9, 2024
| _PILLOW_RE: Final = re.compile(r"^PIL\..*") | ||
|
|
||
|
|
||
| def is_pillow_image(obj: object) -> bool: |
There was a problem hiding this comment.
@LukasMasuch do we need this function as part of this PR?
There was a problem hiding this comment.
Ahh, good catch. Not really, for this specific PR. But for another lazy-loading PR.
There was a problem hiding this comment.
Will merge with this method for now, since I anyways will wrap up the other PR that needs it today. And it our CI doesn't work right now I would do another commit.
kajarenc
approved these changes
Feb 9, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
## Describe your changes Lazy-load `pandas` and `pyarrow` only when required (e.g. usage of `st.dataframe`). This PR also includes a couple of other small refactorings related to typing and imports. ## GitHub Issue Link (if applicable) Related to streamlit#6066 ## Testing Plan - Added e2e test to ensure that `pyarrow` and `pandas` are lazy-loaded. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Lazy-load
pandasandpyarrowonly when required (e.g. usage ofst.dataframe).This PR also includes a couple of other small refactorings related to typing and imports.
GitHub Issue Link (if applicable)
Related to #6066
Testing Plan
pyarrowandpandasare lazy-loaded.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.