Support multiple path characteristics for switch_page and page_link #8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
force-pushed
the
fix/page-path
branch
2 times, most recently
from
8eff09c
to
71a29e4
Compare
kajarenc
reviewed
Feb 9, 2024
lib/streamlit/file_util.py
Outdated
Comment on lines
226
to
227
| main_script_path = os.path.join(os.getcwd(), main_script) | ||
| main_script_path = os.path.normpath(main_script_path) |
There was a problem hiding this comment.
Suggested change
| main_script_path = os.path.join(os.getcwd(), main_script) | |
| main_script_path = os.path.normpath(main_script_path) | |
| main_script_path = normalize_path_join(os.getcwd(), main_script) |
Is there any reason not to reuse normalize_path_join in get_main_script_directory
I think we could replace these two lines with the normalize_path_join function call
kajarenc
approved these changes
Feb 9, 2024
kmcgrady
force-pushed
the
fix/page-path
branch
from
71a29e4
to
00f0017
Compare
kmcgrady
added a commit
that referenced
this pull request
Feb 9, 2024
…8127) ## Describe your changes The changes made improve page path calculation, but don't support file path scenarios with `..`, etc. This change aims to clean up the logic and ensure it's consistent. ## Testing Plan - Unit Tests - Tested the file path methods to cover all the use cases - Manual Testing - Testing on Windows and Mac --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…treamlit#8127) ## Describe your changes The changes made improve page path calculation, but don't support file path scenarios with `..`, etc. This change aims to clean up the logic and ensure it's consistent. ## Testing Plan - Unit Tests - Tested the file path methods to cover all the use cases - Manual Testing - Testing on Windows and Mac --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The changes made improve page path calculation, but don't support file path scenarios with
.., etc. This change aims to clean up the logic and ensure it's consistent.Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.