Lazy-load unittest, packaging, and openmetrics proto
#8150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
changed the title
unittest, packaging, and openmetrics proto
LukasMasuch
requested review from
vdonato and
sfc-gh-mnowotka
as code owners
| @@ -101,7 +106,7 @@ def _get_error_message_args( | |||
| self, | |||
| orig_exc: BaseException, | |||
| failed_obj: Any, | |||
| ) -> Dict[str, Any]: | |||
| ) -> dict[str, Any]: | |||
There was a problem hiding this comment.
nit: Is this necessary?
There was a problem hiding this comment.
these are the new/future annotations. The upper case versions are the old way of typing these structures. Vincent already started adding that in a couple of modules and I have been preparing a bigger PR to update that across our codebase here: https://github.com/streamlit/streamlit/pulls
sfc-gh-wihuang
approved these changes
Feb 13, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
) ## Describe your changes This is the final lazy-loading PR for now. It lazy-loads the following modules: - `unittest` - `packaging` - `streamlit.proto.openmetrics_data_model_pb2` This PR also includes a couple of other refactorings related to typing and imports. ## GitHub Issue Link (if applicable) - Closes streamlit#6066 ## Testing Plan - Add lazy-loaded modules to e2e test. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is the final lazy-loading PR for now. It lazy-loads the following modules:
unittestpackagingstreamlit.proto.openmetrics_data_model_pb2This PR also includes a couple of other refactorings related to typing and imports.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.