Fix chart exception where color-handling code expected DF index to start at 0 #8158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
LGTM 👍 We recently had a community contribution to fix the same issue for st.map here: #8079 The PR used iloc, but I think iat is the better choice for this. It might be good to just update the iloc usage to iat in st.map as well.
|
Yeah, I saw the .iloc there but didn't want to touch it since it's working 😄 Did they contribute a test specifically for that bug in st.map? If so, I'll happily change to .iat right now |
|
Oh, actually I do see tests. I'll change it to .iat, BRB |
|
Done. PTAL |
|
Perfect, looks great 👍 Merging it now (not sure if you have merging permission?) |
|
Thanks! I was just waiting for a final review 😉 |
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…art at 0 (streamlit#8158) ## Describe your changes Fixes an exception in our native st.foo_chart commands, where color-handling code expected DF index to start at 0. So, for example, the code below used to throw an exception: ```python df = pd.DataFrame( { "a": [11, 2, 55], "b": [100, 101, 102], "c": [200, 201, 202], "d": [300, 301, 302], } ) df.set_index("a", inplace=True) st.line_chart(df, x="b", y="c", color="d") ``` ## GitHub Issue Link (if applicable) None. ## Testing Plan - ~~Explanation of why no additional tests are needed~~ - [x] Unit Tests (JS and/or Python) - ~~E2E Tests~~ - Any manual testing needed? - **No** --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes an exception in our native st.foo_chart commands, where color-handling code expected DF index to start at 0.
So, for example, the code below used to throw an exception:
GitHub Issue Link (if applicable)
None.
Testing Plan
Explanation of why no additional tests are neededE2E TestsContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.