New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase time until timeout warning is shown for a custom component #8179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
commented
Feb 19, 2024
} | ||
|
||
const RawSkeleton: FC<React.PropsWithChildren<Props>> = props => { | ||
return <SquareSkeleton data-testid="stSkeleton" {...props} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change allows us to pass a height to the loading skeleton
raethlein
force-pushed
the
7046-custom-component-loading-indicator
branch
2 times, most recently
from
February 19, 2024 17:55
366ab45
to
485b4bf
Compare
willhuang1997
approved these changes
Feb 20, 2024
sfc-gh-wihuang
approved these changes
Feb 21, 2024
In the meantime, show the loading Skeleton
raethlein
force-pushed
the
7046-custom-component-loading-indicator
branch
from
February 21, 2024 21:19
e2c4e65
to
370e5bc
Compare
This was referenced Mar 12, 2024
Open
@raethlein just opened an issue that I think deals with this PR here: #8285 Is it possible that this PR changed how heights are calculated for custom components inconsistently? |
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…shown (streamlit#8179) - Rewrites ComponentInstance from React class component to React functional component - Warning element when component cannot be loaded is shown after 60 seconds instead of 3 seconds - A warning log is issued after 15 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7046
While the custom component is loaded, we show the loading skeleton. Following changes are made in this PR:
url
is provided (usually dev mode) or notcomponentUtils.ts
component-lib/
module and we could think about creating a shared module so that we do not duplicate the typing etc. However, I consider this to be out of scope for this PR.Screenshot of warning messages
Screenshot of loading skeletons
Describe your changes
GitHub Issue Link (if applicable)
Testing Plan
componentUtil.ts
fileSkeleton.test.ts
to check for passed height propertyContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.