Fully clear App State on page change #8208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
changed the title
mayagbarnes
approved these changes
Feb 27, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
## Describe your changes We had a bug where stale elements of the old page remain visible to users on the new page. We want update our `pendingElementBuffer` based on new state and not from the original closure. ## Testing Plan - Unit Test for this specific scenario - E2E test is difficult to implement due to the ephemeral nature of this edge case. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We had a bug where stale elements of the old page remain visible to users on the new page. We want update our
pendingElementBufferbased on new state and not from the original closure.Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.