Fix infinite loop when rerun and triggered widgets are used together in AppTest
#8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
approved these changes
Mar 8, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…r in AppTest (streamlit#8264) ## Describe your changes Reverts a previous fix that made trigger values correct in AppTest but introduced an infinite recursion when `st.rerun()` is called conditionally on the value of a trigger widget. Instead, making trigger widgets return correct values in AppTest is handled by storing their values at runtime using the new `save_for_app_testing` functionality introduced by streamlit#8189 ## GitHub Issue Link (if applicable) streamlit#7768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Reverts a previous fix that made trigger values correct in AppTest but introduced an infinite recursion when
st.rerun()is called conditionally on the value of a trigger widget. Instead, making trigger widgets return correct values in AppTest is handled by storing their values at runtime using the newsave_for_app_testingfunctionality introduced by #8189GitHub Issue Link (if applicable)
#7768
Testing Plan
Regression test added
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.