Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the button width as minimum for st.popover container #8266

Merged
merged 1 commit into from Mar 11, 2024

Conversation

LukasMasuch
Copy link
Collaborator

@LukasMasuch LukasMasuch commented Mar 8, 2024

Describe your changes

If use_container_width==true is set for st.popover, we use the container width as minimum width for the popover container.

GitHub Issue Link (if applicable)

Closes #8261

Testing Plan

  • Added e2e test

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@LukasMasuch LukasMasuch changed the title Use container width as minimum for popover container Use the button width as minimum for st.popover container Mar 8, 2024
@LukasMasuch LukasMasuch marked this pull request as ready for review March 8, 2024 22:21
@LukasMasuch LukasMasuch merged commit b1dd9f8 into develop Mar 11, 2024
47 of 48 checks passed
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
…#8266)

## Describe your changes

If `use_container_width==true` is set for `st.popover`, we use the
container width as minimum width for the popover container.

## GitHub Issue Link (if applicable)

Closes streamlit#8261

## Testing Plan

- Added e2e test

---

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover content width should respect wide layout if specified
2 participants