Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selections to st.altair_chart & st.vega_lite_chart #8302

Merged
merged 354 commits into from
May 14, 2024
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Apr 15, 2024

  1. Configuration menu
    Copy the full SHA
    beb64fd View commit details
    Browse the repository at this point in the history
  2. Add new altair tests

    willhuang1997 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5f814e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d4931c View commit details
    Browse the repository at this point in the history
  4. Fix e2e tests

    willhuang1997 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    37a21c0 View commit details
    Browse the repository at this point in the history
  5. Upgrade altair version

    willhuang1997 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b4b3ce4 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    ed65b35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27edf8b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba3bb08 View commit details
    Browse the repository at this point in the history
  4. Fix data bug

    willhuang1997 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0a2254a View commit details
    Browse the repository at this point in the history
  5. Fix altair tests

    willhuang1997 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7eab15a View commit details
    Browse the repository at this point in the history
  6. Attempt to fix tests

    willhuang1997 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8d3e8d9 View commit details
    Browse the repository at this point in the history
  7. Attempt to move skip

    willhuang1997 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    776973b View commit details
    Browse the repository at this point in the history
  8. Readd watchdog

    willhuang1997 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c461059 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dad5a51 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    41b4260 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    4744ea0 View commit details
    Browse the repository at this point in the history
  2. Fix internal method

    willhuang1997 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    187c737 View commit details
    Browse the repository at this point in the history
  3. Fix comment

    willhuang1997 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    cdcfb48 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    510d0da View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    95f0375 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e1b7bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    018da37 View commit details
    Browse the repository at this point in the history
  4. Fix type errors

    willhuang1997 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    97a3cf3 View commit details
    Browse the repository at this point in the history
  5. Minor fixes

    willhuang1997 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0926d46 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Evaluate different mechanism to keep plotly state (#8515)

    ## Describe your changes
    
    Use a different mechanism using `onUpdated` callback to keep the Plotly
    state.
    
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    
    ---------
    
    Co-authored-by: William Wei Huang <william.huang@snowflake.com>
    LukasMasuch and sfc-gh-wihuang committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b0e60a3 View commit details
    Browse the repository at this point in the history
  2. Attempt to remove bool for on select param (#8525)

    <!--
    ⚠️ BEFORE CONTRIBUTING PLEASE READ OUR CONTRIBUTING GUIDELINES!
    https://github.com/streamlit/streamlit/wiki/Contributing
    -->
    
    ## Describe your changes
    - refactor removing boolean because "rerun" and "ignore" are the
    preferred ways of setting `on_select`
    - should likely wait to get this PR in until other PRs such as
    #8522 and
    #8515 are merged
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    
    ---------
    
    Co-authored-by: lukasmasuch <lukas.masuch@gmail.com>
    willhuang1997 and LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b59fb6b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e19c5d6 View commit details
    Browse the repository at this point in the history
  4. Merge branches 'feature/InteractiveCharts_Plotly' and 'feature/Intera…

    …ctiveCharts_Plotly' of https://github.com/streamlit/streamlit into feature/InteractiveCharts_Plotly
    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    4bfedbb View commit details
    Browse the repository at this point in the history
  5. Add signature overloading

    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    eb34b64 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a91f97a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8303ec2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    21e7333 View commit details
    Browse the repository at this point in the history
  9. Improve reset handling

    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6ab5fa3 View commit details
    Browse the repository at this point in the history
  10. Add some more checks

    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a3d252e View commit details
    Browse the repository at this point in the history
  11. Add more logs

    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8017db6 View commit details
    Browse the repository at this point in the history
  12. Fix issue

    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    62c1469 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    50ea41e View commit details
    Browse the repository at this point in the history
  14. Change default to ignore

    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c07c4ab View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    99f361c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e4ed5c1 View commit details
    Browse the repository at this point in the history
  17. Fix fragment support

    LukasMasuch committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e27ae39 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    aadc196 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Further fixes

    LukasMasuch committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    e2f61a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bd9db0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    772a562 View commit details
    Browse the repository at this point in the history
  4. Clean up safe types

    LukasMasuch committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    788483a View commit details
    Browse the repository at this point in the history
  5. Minor refactorings

    LukasMasuch committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    d97a1db View commit details
    Browse the repository at this point in the history
  6. More refactorings

    LukasMasuch committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    3131a11 View commit details
    Browse the repository at this point in the history
  7. Add more dependencies

    LukasMasuch committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    960492c View commit details
    Browse the repository at this point in the history
  8. Remove not needed code

    LukasMasuch committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    9d58e8e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    69158f0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2845400 View commit details
    Browse the repository at this point in the history
  11. Minor refactoring

    LukasMasuch committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    045f83e View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Apply more improvements

    LukasMasuch committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    4eb6a83 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary check

    LukasMasuch committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    21ea00e View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. More refactoring

    LukasMasuch committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    74dc9b9 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Remove some comments

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    802cf40 View commit details
    Browse the repository at this point in the history
  2. Fix typechecking for Interactive Plotly Charts (#8550)

    ## Describe your changes
    - best attempt to fix typechecking for plotly
    - there is one # type: ignore at line 185 because mypy is not
    recognizing that they're compatible sets
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    willhuang1997 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e80cbf4 View commit details
    Browse the repository at this point in the history
  3. Refactor types

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    59e521f View commit details
    Browse the repository at this point in the history
  4. Remove unused interface

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cafc9fb View commit details
    Browse the repository at this point in the history
  5. Remove more console logs

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5fb06f1 View commit details
    Browse the repository at this point in the history
  6. Add tracing

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ba9640e View commit details
    Browse the repository at this point in the history
  7. Revert

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    55dd677 View commit details
    Browse the repository at this point in the history
  8. Remove todo comment

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f0b6f17 View commit details
    Browse the repository at this point in the history
  9. Remove console log

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    08e84fd View commit details
    Browse the repository at this point in the history
  10. Small move

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    674ed41 View commit details
    Browse the repository at this point in the history
  11. More cleanup

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2e2e67e View commit details
    Browse the repository at this point in the history
  12. Fix Python tests for Interactive Plotly Charts (#8551)

    ## Describe your changes
    - fix python tests
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    
    ---------
    
    Co-authored-by: Lukas Masuch <Lukas.Masuch@gmail.com>
    willhuang1997 and LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8a016dd View commit details
    Browse the repository at this point in the history
  13. Fix Playwright tests for Interactive Plotly Charts (#8552)

    ## Describe your changes
    - new fullscreen changes have come in so need to fix the playwright code
    to look for new full screen / exit full screen buttons
    - new fullscreen changes so snapshots likely need to be regenerated
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    
    ---------
    
    Co-authored-by: Lukas Masuch <Lukas.Masuch@gmail.com>
    willhuang1997 and LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0073042 View commit details
    Browse the repository at this point in the history
  14. Use Widget Callback

    LukasMasuch committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    326d1ff View commit details
    Browse the repository at this point in the history
  15. Remove default height

    willhuang1997 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    eb8da4d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2500722 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a01549c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    d7efda0 View commit details
    Browse the repository at this point in the history
  19. Fix typing

    willhuang1997 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6ac7bef View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    ff5c2d1 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    10b9f14 View commit details
    Browse the repository at this point in the history
  22. Fix lint

    willhuang1997 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    67de052 View commit details
    Browse the repository at this point in the history
  23. Add snapshots

    willhuang1997 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ff93577 View commit details
    Browse the repository at this point in the history
  24. Fix failing snapshots

    willhuang1997 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fe14ecd View commit details
    Browse the repository at this point in the history
  25. Fix snapshots

    willhuang1997 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2702bb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Add Interactive Plotly typescript unit tests (#8557)

    ## Describe your changes
    - title
    - added tests for:
      - `sendEmptySelection`
      - `handleSelection`
      - `applyTheming`
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    willhuang1997 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    57352f4 View commit details
    Browse the repository at this point in the history
  2. Fix double click Plotly behavior (#8561)

    ## Describe your changes
    - null was being passed to resetSelectionInFigure because Plotly will
    pass in null. As a result, we need to actually call the function ourself
    to get the default value
    - doing this also changes the default plotly pan behavior and also
    resets selections too
    Current:
    
    
    https://github.com/streamlit/streamlit/assets/16749069/cb14a994-7d0f-4425-9c4f-a660ae9248bf
    
    
    Now:
    
    
    https://github.com/streamlit/streamlit/assets/16749069/8820f163-4294-4781-b12d-04d6a750ab12
    
    
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    willhuang1997 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7f2df77 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a94479 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f8aab3 View commit details
    Browse the repository at this point in the history
  5. Fix merge conflict

    willhuang1997 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2453531 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d23b962 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c4fc38d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fd80141 View commit details
    Browse the repository at this point in the history
  9. Move skip in unit test

    willhuang1997 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    daf575f View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. refactors

    willhuang1997 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    baed1d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b505e38 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    66983ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa2f176 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    0ac433e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ac4548 View commit details
    Browse the repository at this point in the history
  3. More unit tests

    LukasMasuch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    b985442 View commit details
    Browse the repository at this point in the history
  4. Add another test

    LukasMasuch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    c539481 View commit details
    Browse the repository at this point in the history
  5. Improve test

    LukasMasuch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    f8c408b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9841246 View commit details
    Browse the repository at this point in the history
  7. Deactivate point selection if selection mode doesn't include points (#…

    …8574)
    
    ## Describe your changes
    
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    
    ---------
    
    Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
    LukasMasuch and willhuang1997 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    54a8323 View commit details
    Browse the repository at this point in the history
  8. Remove unnecessary buttons in Plotly toolbar (#8571)

    ## Describe your changes
    - removes config buttons even for non-selection plotly charts
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    
    ---------
    
    Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
    sfc-gh-wihuang and willhuang1997 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    06d6c5d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6b41328 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    efaacc8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fc4b23f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4ef76c8 View commit details
    Browse the repository at this point in the history
  13. Recreate snapshots

    LukasMasuch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ba962fa View commit details
    Browse the repository at this point in the history
  14. Fix plotly tab change flickering (#8577)

    ## Describe your changes
    
    Improve the flickering issue when the width of the vertical block isn't
    determined yet (==-1).
    
    ## GitHub Issue Link (if applicable)
    
    - Related: #8575
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    LukasMasuch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    cf3e62d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    06244c7 View commit details
    Browse the repository at this point in the history
  16. Add updated snapshots

    LukasMasuch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7fb856a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9933844 View commit details
    Browse the repository at this point in the history
  18. Some cleanups

    LukasMasuch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ac84eb2 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Configuration menu
    Copy the full SHA
    7031468 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    51db920 View commit details
    Browse the repository at this point in the history
  2. Fix Interactive Plotly e2e playwright nits (#8579)

    ## Describe your changes
    - add new tests
      - unmounting + mounting
      - choropleth chart (readded and uncommented out)
    - fix some minor nits such as removing updating layout and removing
    session_state checks
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    
    ---------
    
    Co-authored-by: Lukas Masuch <Lukas.Masuch@gmail.com>
    willhuang1997 and LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    05304ae View commit details
    Browse the repository at this point in the history
  3. Mini changes

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    56c6407 View commit details
    Browse the repository at this point in the history
  4. Minor fine-tuning

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bd74635 View commit details
    Browse the repository at this point in the history
  5. More improvements

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    03f7e5e View commit details
    Browse the repository at this point in the history
  6. Some more tweaks

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6c4817c View commit details
    Browse the repository at this point in the history
  7. More tweaks

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a423efe View commit details
    Browse the repository at this point in the history
  8. Remove test

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    071204a View commit details
    Browse the repository at this point in the history
  9. More fine-tuning

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f1ba990 View commit details
    Browse the repository at this point in the history
  10. Click somewhere else

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2995b74 View commit details
    Browse the repository at this point in the history
  11. More fine-tuning

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3b0a738 View commit details
    Browse the repository at this point in the history
  12. Update snapshots

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d5454ae View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d4d0b0a View commit details
    Browse the repository at this point in the history
  14. More changes

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0e88d7b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    00c50e1 View commit details
    Browse the repository at this point in the history
  16. Minor proto restructuring

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4e4421d View commit details
    Browse the repository at this point in the history
  17. Remove flakiness

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    50caac6 View commit details
    Browse the repository at this point in the history
  18. Update snapshots

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c61d197 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    2eb72f7 View commit details
    Browse the repository at this point in the history
  20. Add unit test for box and lasso selection (#8585)

    ## Describe your changes
    - add unit test for box AND lasso selection with mock data
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    69b95ef View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    2a55a67 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    ce3aa20 View commit details
    Browse the repository at this point in the history
  23. Add new snapshots

    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7b9a522 View commit details
    Browse the repository at this point in the history
  24. Add new snapshots

    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e5bb687 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    7374c92 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    9b0a727 View commit details
    Browse the repository at this point in the history
  27. Improve docstring

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f738771 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    27cf334 View commit details
    Browse the repository at this point in the history
  29. add final new snapshot

    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    276ed8f View commit details
    Browse the repository at this point in the history
  30. Remove choropleth chart

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bb770bf View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    efa0b79 View commit details
    Browse the repository at this point in the history
  32. Update snapshots

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dda8ba6 View commit details
    Browse the repository at this point in the history
  33. Improve test

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cd2e96d View commit details
    Browse the repository at this point in the history
  34. Fix test

    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    15df246 View commit details
    Browse the repository at this point in the history
  35. Fix test

    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8fefff5 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    a142b3d View commit details
    Browse the repository at this point in the history
  37. Use direct chart click

    LukasMasuch committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7d32594 View commit details
    Browse the repository at this point in the history
  38. Add new screenshots(?)

    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1def33f View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    c7609f2 View commit details
    Browse the repository at this point in the history
  40. Fix imports

    willhuang1997 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ed37b7f View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    5d66f3c View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. [InteractiveChartsAltair] Form support for Interactive charts altair (#…

    …8549)
    
    ## Describe your changes
    - added form support
    - refactored to use "rerun" only instead of booleans
    - refactor streamlit altair 4 exception message
    ## GitHub Issue Link (if applicable)
    
    ## Testing Plan
    
    - Explanation of why no additional tests are needed
    - Unit Tests (JS and/or Python)
    - E2E Tests
    - Any manual testing needed?
    
    ---
    
    **Contribution License Agreement**
    
    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.
    willhuang1997 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4e3a9fc View commit details
    Browse the repository at this point in the history
  2. Fix nits and codeql

    willhuang1997 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    156e9ac View commit details
    Browse the repository at this point in the history
  3. Refactor constants

    willhuang1997 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    563fd4d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ba8dbab View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    44943a1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    081b5d3 View commit details
    Browse the repository at this point in the history
  7. Add snapshots

    willhuang1997 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e48923d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    06c1e47 View commit details
    Browse the repository at this point in the history
  9. Remove unnecessary code

    willhuang1997 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    84b7433 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Configuration menu
    Copy the full SHA
    c5abc9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da143df View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0b0361b View commit details
    Browse the repository at this point in the history
  4. Attempt to move import

    willhuang1997 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6a93f7a View commit details
    Browse the repository at this point in the history
  5. Fix nit

    willhuang1997 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0841ded View commit details
    Browse the repository at this point in the history
  6. Move imports

    willhuang1997 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    736d946 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eb65c26 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    a45ad4c View commit details
    Browse the repository at this point in the history
  2. Some small refactorings

    LukasMasuch committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cb71d6b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Move to widgets

    LukasMasuch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c19bfa1 View commit details
    Browse the repository at this point in the history
  2. Sort widgets list

    LukasMasuch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b883d09 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cd4f816 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5d3ca7e View commit details
    Browse the repository at this point in the history
  5. Add better comments

    LukasMasuch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2cb52de View commit details
    Browse the repository at this point in the history
  6. Clean up yarn lock file

    LukasMasuch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8e1f48c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    dae3de3 View commit details
    Browse the repository at this point in the history
  2. Add properties

    LukasMasuch committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e9b9a47 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    6d600b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83ed8b3 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    0d1e316 View commit details
    Browse the repository at this point in the history
  2. Remove generated code

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5b945e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8bf2e7 View commit details
    Browse the repository at this point in the history
  4. Move import

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    35380ab View commit details
    Browse the repository at this point in the history
  5. Improve comments

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    96986df View commit details
    Browse the repository at this point in the history
  6. Add additional test

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    0f267b7 View commit details
    Browse the repository at this point in the history
  7. Fix unit test

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    81af60c View commit details
    Browse the repository at this point in the history
  8. Fix types

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    828b8b6 View commit details
    Browse the repository at this point in the history
  9. Add comment

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f2ee02c View commit details
    Browse the repository at this point in the history
  10. Move something

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d655915 View commit details
    Browse the repository at this point in the history
  11. Update proto comments

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4d654f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4ca05b0 View commit details
    Browse the repository at this point in the history
  13. Fix unit tests

    LukasMasuch committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2c4d1c9 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    5d9d7a8 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    c0858ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6a189f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ff5714d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9e7d5a3 View commit details
    Browse the repository at this point in the history
  5. Update e2e tests

    raethlein committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6ed8ed5 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Disallow composite charts

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    0667b62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c21857 View commit details
    Browse the repository at this point in the history
  3. Add more comments

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    85a09bf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    928a3f0 View commit details
    Browse the repository at this point in the history
  5. Some more refactoring

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    3f3dde9 View commit details
    Browse the repository at this point in the history
  6. Clean up logs

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    1528976 View commit details
    Browse the repository at this point in the history
  7. Introduce selection modes

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    0d4a3df View commit details
    Browse the repository at this point in the history
  8. Fix issue

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    7c364b2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    05382c1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b28724a View commit details
    Browse the repository at this point in the history
  11. Remove utils method

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    efbfb7d View commit details
    Browse the repository at this point in the history
  12. Remove the state variable

    LukasMasuch committed May 12, 2024
    Configuration menu
    Copy the full SHA
    b0b0171 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Clean up console logs

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    15a2a39 View commit details
    Browse the repository at this point in the history
  2. Use more local datasets

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6927999 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    58a39de View commit details
    Browse the repository at this point in the history
  4. Add more comments

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    543509d View commit details
    Browse the repository at this point in the history
  5. Simplify code

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    28fea60 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5a1ab9c View commit details
    Browse the repository at this point in the history
  7. Update e2e tests

    raethlein committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7c6474b View commit details
    Browse the repository at this point in the history
  8. Some small refinements

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    bf70184 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5971324 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e0cacf1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3e9685d View commit details
    Browse the repository at this point in the history
  12. Fix typing issue

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7ed071a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    11457bf View commit details
    Browse the repository at this point in the history
  14. Fix unit tests

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2b925da View commit details
    Browse the repository at this point in the history
  15. Add future annotations

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6b45d68 View commit details
    Browse the repository at this point in the history
  16. Fix test

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    03ee086 View commit details
    Browse the repository at this point in the history
  17. Fix typing issues

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4ea99fb View commit details
    Browse the repository at this point in the history
  18. Add more tests

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    21757fa View commit details
    Browse the repository at this point in the history
  19. Improve unit tests

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ce891f9 View commit details
    Browse the repository at this point in the history
  20. Remove print

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    08a0729 View commit details
    Browse the repository at this point in the history
  21. Fix test

    LukasMasuch committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0385266 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Update tests

    raethlein committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e82ea5e View commit details
    Browse the repository at this point in the history
  2. Apply review comments

    LukasMasuch committed May 14, 2024
    Configuration menu
    Copy the full SHA
    aa982ae View commit details
    Browse the repository at this point in the history
  3. Update comment

    LukasMasuch committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6b2d820 View commit details
    Browse the repository at this point in the history
  4. Simplify removal

    LukasMasuch committed May 14, 2024
    Configuration menu
    Copy the full SHA
    83ea606 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5808e4d View commit details
    Browse the repository at this point in the history
  6. Update comment

    LukasMasuch committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c66a2ca View commit details
    Browse the repository at this point in the history
  7. Use regex in e2e tests

    raethlein committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e2a686e View commit details
    Browse the repository at this point in the history
  8. Update e2e test regexes

    raethlein committed May 14, 2024
    Configuration menu
    Copy the full SHA
    00ba60b View commit details
    Browse the repository at this point in the history
  9. Update e2e test regexes

    raethlein committed May 14, 2024
    Configuration menu
    Copy the full SHA
    81f126c View commit details
    Browse the repository at this point in the history
  10. Update e2e test regexes

    raethlein committed May 14, 2024
    Configuration menu
    Copy the full SHA
    75b27c3 View commit details
    Browse the repository at this point in the history
  11. Update snapshots

    raethlein committed May 14, 2024
    Configuration menu
    Copy the full SHA
    724c9ad View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    82f0193 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4513655 View commit details
    Browse the repository at this point in the history
  14. Update snapshots

    LukasMasuch committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e02eee5 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7632c88 View commit details
    Browse the repository at this point in the history
  16. Update snapshots

    raethlein committed May 14, 2024
    Configuration menu
    Copy the full SHA
    13146b2 View commit details
    Browse the repository at this point in the history