Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple fix to update container status after llm complete #8311

Merged
merged 5 commits into from Mar 25, 2024
Merged

Add simple fix to update container status after llm complete #8311

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de131db
add simple fix to update container status after llm complete
KedoKudo Mar 15, 2024
f630684
use the complete method as suggested
KedoKudo Mar 18, 2024
6abbb79
revert the chagnes to expaneded arg
KedoKudo Mar 25, 2024
7480d71
adopt suggestion for on_llm_error
KedoKudo Mar 25, 2024
6f86365
Fix typo
vdonato Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/streamlit/external/langchain/streamlit_callback_handler.py
View file
Open in desktop
Expand Up @@ -189,11 +189,13 @@ def on_llm_end(self, response: LLMResult, **kwargs: Any) -> None:
# If we're receiving streaming tokens from `on_llm_new_token`, this response
# data is redundant
self._reset_llm_token_stream()
# set the container status to complete
self.complete(self._labeler.get_final_agent_thought_label())

def on_llm_error(self, error: BaseException, *args: Any, **kwargs: Any) -> None:
self._container.markdown("**LLM encountered an error...**")
self._container.exception(error)
self._state = LLMThoughtState.ERROR
self.complete("LLM encountered an error...")

def on_tool_start(
self, serialized: dict[str, Any], input_str: str, **kwargs: Any
Expand Down