Migrate typography-cypress test to playwright #8594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
commented
May 2, 2024
Comment on lines
-39
to
-41
| st.markdown("# Some header 1") | ||
| st.markdown("## Some header 2") | ||
| st.markdown("### Some header 3") |
There was a problem hiding this comment.
I removed these because in the bottom of this file we have a couple of different header tests now, so these are not needed anymore
raethlein
commented
May 2, 2024
| @@ -55,40 +51,10 @@ | |||
| ":green-background[LaTeX math within green background: $ax^2 + bx + c = 0$]" | |||
| ) | |||
|
|
|||
| with st.container(): | |||
| st.markdown("# some really long header " + " ".join(["lol"] * 10)) | |||
There was a problem hiding this comment.
moved this test down to the other header tests
raethlein
commented
May 2, 2024
Comment on lines
+100
to
+179
| def draw_header_test(join_output): | ||
| strings = [ | ||
| "# Header header1", | ||
| "## Header header2", | ||
| "### Header header3", | ||
| "#### Header header4", | ||
| "##### Header header5", | ||
| "###### Header header6", | ||
| "Quisque vel blandit mi. Fusce dignissim leo purus, in imperdiet lectus suscipit nec.", | ||
| ] | ||
|
|
||
| if join_output: | ||
| st.markdown("\n\n".join(strings)) | ||
| else: | ||
| for string in strings: | ||
| st.markdown(string) | ||
|
|
||
|
|
||
| draw_header_test(True) | ||
|
|
||
| with st.sidebar: | ||
| st.text_input("This is a label", key="1") | ||
| draw_header_test(True) | ||
|
|
||
| "---" | ||
|
|
||
| with st.container(): | ||
| st.text("Headers in single st.markdown command") | ||
| draw_header_test(True) | ||
|
|
||
| "---" | ||
|
|
||
| with st.container(): | ||
| st.text("Headers in multiple st.markdown command") | ||
| draw_header_test(False) | ||
|
|
||
| "---" | ||
|
|
||
| with st.container(): | ||
| st.text("Headers in columns") | ||
|
|
||
| a, b = st.columns(2) | ||
|
|
||
| with a: | ||
| draw_header_test(True) | ||
|
|
||
| with b: | ||
| draw_header_test(False) | ||
|
|
||
| "---" | ||
|
|
||
| with st.container(): | ||
| st.text("Headers in columns with other elements above") | ||
|
|
||
| a, b = st.columns(2) | ||
|
|
||
| with a: | ||
| st.text("This is some text") | ||
| draw_header_test(True) | ||
|
|
||
| with b: | ||
| st.text("This is some text") | ||
| with st.container(): | ||
| draw_header_test(False) | ||
|
|
||
| "---" | ||
|
|
||
| with st.container(): | ||
| st.text("Headers in column beside widget") | ||
|
|
||
| a, b = st.columns(2) | ||
|
|
||
| with a: | ||
| st.write("# Header header") | ||
| st.write("## Header header") | ||
|
|
||
| with b: | ||
| st.text_input("This is a label", key="2") | ||
|
|
||
| "---" |
There was a problem hiding this comment.
This is the existing typography test code that is migrated in this PR from Cypress
raethlein
added
security-assessment-completed
impact:internal
change:refactor
change:chore
and removed
change:refactor
labels
raethlein
changed the title
raethlein
force-pushed
the
tests/migrate-typography-to-playwright
branch
2 times, most recently
from
277bcbe
to
836f29a
Compare
LukasMasuch
reviewed
May 2, 2024
|
|
||
| # take the 2nd match because the first would be the most outer block | ||
| return ( | ||
| app.get_by_test_id("stVerticalBlock") |
There was a problem hiding this comment.
clever :) But would be even simpler if we could add a class to a container via key. Hopefully, we can add that soon.
LukasMasuch
approved these changes
May 2, 2024
...napshots__/linux/st_markdown_test/st_markdown-num_elements_displayed[dark_theme-firefox].png
Outdated
Show resolved
Hide resolved
raethlein
force-pushed
the
tests/migrate-typography-to-playwright
branch
from
a97b197
to
6444500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR migrates the existing cypress test "typography" to playwright. The test code and cases are merged into the
st_markdowntest as that test file bundles the different markdown scenarios already.In this context, the existing
st_markdowntest is cleaned up a little bit to not double-test headers etc.The migration happens in preparation of the #8587 PR. In that PR a couple of screenshots need to be updated but I don't want to touch the legacy cypress test artifacts.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.