Migrate st.heading cypress test to playwright #8598
Conversation
raethlein
force-pushed
the
tests/migrate-st-header-to-playwright
branch
3 times, most recently
from
c8b6590
to
de0a7dd
Compare
raethlein
changed the title
raethlein
force-pushed
the
tests/migrate-st-header-to-playwright
branch
from
47ba721
to
0cf73e3
Compare
e2e_playwright/st_heading.py
Outdated
| @@ -22,11 +22,25 @@ | |||
| st.title("`Code` - Title with Anchor", anchor="title") | |||
There was a problem hiding this comment.
The other header and title cases here do not seem to have a screenshot test. Is that planned to be added later?
There was a problem hiding this comment.
The original cypress test did not have screenshots for them, but good point, I will add it!
There was a problem hiding this comment.
Added more screenshot tests, including hovering over it to see the anchor button etc.
raethlein
force-pushed
the
tests/migrate-st-header-to-playwright
branch
2 times, most recently
from
097b94f
to
5ceea15
Compare
raethlein
force-pushed
the
tests/migrate-st-header-to-playwright
branch
2 times, most recently
from
bd6ffa5
to
854a68f
Compare
raethlein
force-pushed
the
tests/migrate-st-header-to-playwright
branch
from
854a68f
to
60538fd
Compare
|
The https://github.com/streamlit/streamlit/blob/develop/e2e/scripts/st_title.py |
Yep! I have migrated those tests as well into the st_heading test and deleted the Cypress files, thanks for the catch! |
raethlein
force-pushed
the
tests/migrate-st-header-to-playwright
branch
2 times, most recently
from
8c168f1
to
3c8124f
Compare
raethlein
force-pushed
the
tests/migrate-st-header-to-playwright
branch
from
3c8124f
to
55ed99a
Compare
Describe your changes
This PR migrates the existing st_heading and st_subheading tests from Cypress to playwright. Since the two tests touch the same area, they are merged into one test script.
The migration happens in preparation of the #8587 PR. In that PR a couple of screenshots need to be updated but I don't want to touch the legacy cypress test artifacts.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.