Add e2e tests for the dataframe selections #8634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
changed the title
raethlein
force-pushed
the
feature/dataframe-selections-e2e-tests
branch
from
7af0243
to
1150dd6
Compare
LukasMasuch
added a commit
that referenced
this pull request
May 13, 2024
## Describe your changes
This PR adds row and column selection support to `st.dataframe`. It can
be used like this:
```python
selection = st.dataframe(
df,
on_select="rerun",
selection_mode="single-row"
)
```
- [Demo App](https://dataframe-row-selections.streamlit.app/)
https://github.com/streamlit/streamlit/assets/2852129/f3ff476a-0bd0-4b82-bc97-6bda3a3be98c
## GitHub Issue Link (if applicable)
- Closes #688
- Closes #7134
- #455
- #8319
## Testing Plan
- Added unit tests
- Added e2e tests (see #8634)
```[tasklist]
### e2e tests
- [x] Single row/column selection
- [x] Multi row/column selection
- [x] Mixed selections
- [x] Screenshot of a dataframe with multiple selections
- [x] Clear selections via toolbar
- [x] Clear selections via escape
- [x] Select all rows in multi-row selection via top checkbox
- [x] Optional: Test drag and drop selection
- [x] Optional: Test shift selections
- [x] Optional: Test selections in form
- [x] Have some test cases work with session state and others with return value
- [x] Add a test case validating that the callback gets called
```
---
**Contribution License Agreement**
By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
---------
Co-authored-by: Benjamin Räthlein <benjamin.raethlein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds e2e tests for the dataframe row and column selections introduced in this PR: #8411
The tests run fine on my local Mac but not on the CI/CD pipeline yet. Likely something with the Meta key for multiple column selection.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.