Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to autoscaling/v2 #657

Closed
freeznet opened this issue Jun 9, 2023 · 4 comments · Fixed by #658
Closed

Upgrade to autoscaling/v2 #657

freeznet opened this issue Jun 9, 2023 · 4 comments · Fixed by #658
Labels
compute/serverless m/2023-07 type/enhancement Indicates an improvement to an existing feature

Comments

@freeznet
Copy link
Member

freeznet commented Jun 9, 2023

Since k8s 1.23 autoscaling/v2beta2 is deprecated, it will be great if function-mesh upgrades to autoscaling/v2

@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature compute/serverless m/2023-06 labels Jun 9, 2023
@MarkusNeuron
Copy link
Contributor

Hi guys, this is the only thing blocking us from an needed cluster upgrade. This should be very easy to fix. Thanks for your consideration!

@MarkusNeuron
Copy link
Contributor

Hi, just as info: We forked function mesh and did a "stupid" search and replace on "v2beta2" => "v2", rebuild and containerised the code and it works fine for us. So my comment above is still valid 😄 .

@freeznet
Copy link
Member Author

hi @MarkusNeuron, your solution should be okay according to https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v126.
Would you mind opening a PR for the fix? thanks.

@MarkusNeuron
Copy link
Contributor

MarkusNeuron commented Jun 30, 2023

Hi @freeznet,
please have a look: #658

@freeznet freeznet mentioned this issue Jul 25, 2023
4 tasks
@freeznet freeznet added this to the 2023-07 v0.15.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compute/serverless m/2023-07 type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants