Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to autoscaling/v2 #658

Merged
merged 10 commits into from Jul 25, 2023
Merged

move to autoscaling/v2 #658

merged 10 commits into from Jul 25, 2023

Conversation

MarkusNeuron
Copy link
Contributor

@MarkusNeuron MarkusNeuron commented Jun 30, 2023 •
edited by freeznet

fix #657

Kubernetes 1.26 deprecated the autoscaling/v2beta2 API version of HorizontalPodAutoscaler. See details.

This PR switches the API to v2 for compatibility.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@MarkusNeuron MarkusNeuron requested review from nlu90, freeznet and a team as code owners June 30, 2023 12:42
@github-actions
Copy link

@MarkusNeuron:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jun 30, 2023
@MarkusNeuron MarkusNeuron mentioned this pull request Jun 30, 2023
Closed
@MarkusNeuron
Update CHANGELOG.md
811df86 
Revert change to documenation
@freeznet
Copy link
Member

freeznet commented Jul 5, 2023

@MarkusNeuron thanks for the PR, I think it will need to upgrade the k8s version from kindest/node:v1.22.15 to kindest/node:v1.26.6 to fix the CI. would you please do a full text search of 1.22.15 on the repo and replace it to 1.26.6?

@MarkusNeuron
Copy link
Contributor Author

MarkusNeuron commented Jul 5, 2023 •
edited

@MarkusNeuron thanks for the PR, I think it will need to upgrade the k8s version from kindest/node:v1.22.15 to kindest/node:v1.26.6 to fix the CI. would you please do a full text search of 1.22.15 on the repo and replace it to 1.26.6?

Hi, the v2beta2 was deprecated in 1.23+. I am not sure if we directly bump to 1.26.6. For me it would be ok but can you test it? Bumped it..

@jiangpengcheng
Copy link
Member

the sn-platform chart requires kubeVersion: >= 1.19.0-0 <= 1.24.0-0 which is incompatible with Kubernetes v1.26.6, so we cannot bump it to v1.26.6 in CI

@freeznet freeznet mentioned this pull request Jul 18, 2023
Merged
4 tasks
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Jul 25, 2023
@github-actions
Copy link

@MarkusNeuron:Thanks for providing doc info!

@github-actions github-actions bot added the doc-required This pr needs a document label Jul 25, 2023
@freeznet freeznet changed the title Kubernetes 1.26 compatibility / Remove deprecated API move to autoscaling/v2 Jul 25, 2023
@nlu90 nlu90 merged commit 2b4cde0 into streamnative:master Jul 25, 2023
15 checks passed
@Huanli-Meng Huanli-Meng mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeznet freeznet freeznet approved these changes

@nlu90 nlu90 nlu90 approved these changes

Assignees

@MarkusNeuron MarkusNeuron

Labels
doc-required This pr needs a document m/2023-07
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to autoscaling/v2
5 participants
@MarkusNeuron @freeznet @jiangpengcheng @nlu90 @Xellendor