Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Expose some monitor metrics (#106)" #119

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

nlu90
Copy link
Collaborator

@nlu90 nlu90 commented Mar 29, 2023

This reverts commit d7d955c.

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

The metrics reporting code has issues during runtime.
Revert these changes temporarily until we finish the admin dependency cleanup.

23/03/28 16:06:30 INFO PulsarSource: GetBatch generating RDD of offset range: org.apache.spark.sql.pulsar.PulsarOffsetRange@1e815163
23/03/28 16:06:30 INFO MetricsSystem: Metrics already registered
java.lang.IllegalArgumentException: A metric named app-20230328160550-0003.driver.pulsar.spark-pulsar-5dcf5828-6c8c-4654-962c-21e5a630e141.msgRateOut already exists
	at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:156)
	at com.codahale.metrics.MetricRegistry$1.onGaugeAdded(MetricRegistry.java:101)
	at com.codahale.metrics.MetricRegistry.notifyListenerOfAddedMetric(MetricRegistry.java:540)
	at com.codahale.metrics.MetricRegistry.addListener(MetricRegistry.java:381)
	at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:98)
	at org.apache.spark.metrics.MetricsSystem.registerSource(MetricsSystem.scala:165)
	at org.apache.spark.sql.pulsar.PulsarSource.getBatch(PulsarSource.scala:160)
	at org.apache.spark.sql.execution.streaming.MicroBatchExecution.$anonfun$runBatch$3(MicroBatchExecution.scala:496)
	at scala.collection.TraversableLike.$anonfun$flatMap$1(TraversableLike.scala:293)
	at scala.collection.Iterator.foreach(Iterator.scala:943)
	at scala.collection.Iterator.foreach$(Iterator.scala:943)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1431)
	at scala.collection.IterableLike.foreach(IterableLike.scala:74)
	at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
	at org.apache.spark.sql.execution.streaming.StreamProgress.foreach(StreamProgress.scala:27)
	at scala.collection.TraversableLike.flatMap(TraversableLike.scala:293)
	at scala.collection.TraversableLike.flatMap$(TraversableLike.scala:290)
	at org.apache.spark.sql.execution.streaming.StreamProgress.flatMap(StreamProgress.scala:27)
	at org.apache.spark.sql.execution.streaming.MicroBatchExecution.$anonfun$runBatch$2(MicroBatchExecution.scala:492)
	at org.apache.spark.sql.execution.streaming.ProgressReporter.reportTimeTaken(ProgressReporter.scala:375)
	at org.apache.spark.sql.execution.streaming.ProgressReporter.reportTimeTaken$(ProgressReporter.scala:373)
	at org.apache.spark.sql.execution.streaming.StreamExecution.reportTimeTaken(StreamExecution.scala:69)
	at org.apache.spark.sql.execution.streaming.MicroBatchExecution.runBatch(MicroBatchExecution.scala:492)
	at org.apache.spark.sql.execution.streaming.MicroBatchExecution.$anonfun$runActivatedStream$2(MicroBatchExecution.scala:228)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at org.apache.spark.sql.execution.streaming.ProgressReporter.reportTimeTaken(ProgressReporter.scala:375)
	at org.apache.spark.sql.execution.streaming.ProgressReporter.reportTimeTaken$(ProgressReporter.scala:373)
	at org.apache.spark.sql.execution.streaming.StreamExecution.reportTimeTaken(StreamExecution.scala:69)
	at org.apache.spark.sql.execution.streaming.MicroBatchExecution.$anonfun$runActivatedStream$1(MicroBatchExecution.scala:193)
	at org.apache.spark.sql.execution.streaming.ProcessingTimeExecutor.execute(TriggerExecutor.scala:57)
	at org.apache.spark.sql.execution.streaming.MicroBatchExecution.runActivatedStream(MicroBatchExecution.scala:187)
	at org.apache.spark.sql.execution.streaming.StreamExecution.$anonfun$runStream$1(StreamExecution.scala:303)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:775)
	at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:286)
	at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:209)

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@nlu90 nlu90 added this to the 2023-04 v3.2.0.2 milestone Mar 29, 2023
@nlu90 nlu90 requested a review from a team as a code owner March 29, 2023 22:11
@nlu90 nlu90 self-assigned this Mar 29, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Mar 29, 2023
jiangpengcheng
jiangpengcheng previously approved these changes Mar 31, 2023
freeznet
freeznet previously approved these changes Mar 31, 2023
obobj and others added 4 commits April 3, 2023 09:53
* fix: Reader did not closed when an exception occurred in readNext

* fix: Reader did not closed when an exception occurred in readNext
…Helper (#118)

* introduce pulsar consumer for pulsar management

* use consumer cache

* lint error
@nlu90 nlu90 dismissed stale reviews from freeznet and jiangpengcheng via ba351fe April 3, 2023 16:54
@nlu90 nlu90 merged commit 48822bb into master Apr 7, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the neng/revert-metrics-change branch April 7, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants