[Improve] simplify sink schema check #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlu90
changed the title
freeznet
approved these changes
Apr 3, 2023
jiangpengcheng
approved these changes
Apr 3, 2023
nlu90
added a commit
that referenced
this pull request
Apr 3, 2023
nlu90
added a commit
that referenced
this pull request
Apr 7, 2023
* Revert "Expose some monitor metrics (#106)" This reverts commit d7d955c. * Reader need closed when exception (#115) * fix: Reader did not closed when an exception occurred in readNext * fix: Reader did not closed when an exception occurred in readNext * [Improve] replace admin calls with client or consumer calls in PulsarHelper (#118) * introduce pulsar consumer for pulsar management * use consumer cache * lint error * remove admin url from source related components (#120) * simplify sink schema check (#121) --------- Co-authored-by: obobj <vinicolor.violet.end@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #114
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #113
Motivation
The sink will do schema uploading and compatibility check, which can be achieved with the pulsar producer.
When creating the producer, if the topic doesn't exist or topic doesn't have schema, then the schema passed will be uploaded.
If the topic has an existing schema, and it's not compatible with the one used in spark application, an
PulsarClientException.IncompatibileSchemaexception will be thrown.Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)