close producer during cleanup #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (singleProducer != null) { | ||
| singleProducer.close() | ||
| } else { | ||
| topic2Producer.foreach(_._2.close()) |
There was a problem hiding this comment.
Do we need to handle exception here?
There was a problem hiding this comment.
If the exception happens, we will let it propagate.
And it will be catched here: https://github.com/streamnative/pulsar-spark/blob/master/src/main/scala/org/apache/spark/sql/pulsar/PulsarSinks.scala#L153
sijie
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix #136
Currently, producers will stay connected with a broker after each micro-batch, thus causing a broker-side producer spam issue and eventually affecting the broker's performance.
Modifications
call
producer.close()when clean upVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as:
This change added tests and can be verified as follows:
Documentation
Check the box below.
Need to update docs?
doc-requiredno-need-docdoc