Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close producer during cleanup #137

Merged
merged 3 commits into from
Jul 14, 2023
Merged

close producer during cleanup #137

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39c8173
close producer during cleanup
nlu90 Jul 12, 2023
a800010
code style
nlu90 Jul 12, 2023
e88f7f6
code style
nlu90 Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/scala/org/apache/spark/sql/pulsar/PulsarWriteTask.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,11 @@ private[pulsar] abstract class PulsarRowWriter(

protected def producerClose(): Unit = {
producerFlush()
if (singleProducer != null) {
singleProducer.close()
} else {
topic2Producer.foreach(_._2.close())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle exception here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the exception happens, we will let it propagate.

And it will be catched here: https://github.com/streamnative/pulsar-spark/blob/master/src/main/scala/org/apache/spark/sql/pulsar/PulsarSinks.scala#L153

}
topic2Producer.clear()
}
}