feat: add inactive topic policies command for topic #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
inactive_topic
branch
6 times, most recently
from
e1d1290
to
16f8e96
Compare
61 tasks
nodece
force-pushed
the
inactive_topic
branch
from
16f8e96
to
8b43a8f
Compare
zymap
approved these changes
Sep 22, 2021
pkg/ctl/topic/get_inactive_topic.go
Outdated
|
|
||
| import ( | ||
| "github.com/streamnative/pulsarctl/pkg/cmdutils" | ||
|
|
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestInactiveTopicCmd(t *testing.T) { |
There was a problem hiding this comment.
We also need to add some failure case tests.
There was a problem hiding this comment.
I think we just need to test the flag required by set-inactive-topic-policies.
There was a problem hiding this comment.
The failure case is used to check the error response is parsed correctly at the pulsarctl
There was a problem hiding this comment.
Do you want to test the response from pulsar?
nodece
force-pushed
the
inactive_topic
branch
from
8b43a8f
to
07bffc2
Compare
nodece
force-pushed
the
inactive_topic
branch
2 times, most recently
from
b8246b2
to
851cdeb
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
inactive_topic
branch
2 times, most recently
from
a97367d
to
57cdcf0
Compare
zymap
approved these changes
Sep 28, 2021
nodece
added a commit
that referenced
this pull request
Nov 12, 2021
Signed-off-by: Zixuan Liu <nodeces@gmail.com> ### Changes background from #246, the PR implements the following commands: - `pulsarctl topics get-inactive-topic-policies <topic> --applied <bool>` - `pulsarctl topics remove-inactive-topic-policies <topic>` - `pulsarctl topics set-inactive-topic-policies <topic> --enable-delete-while-inactive <bool> --max-inactive-duration <string> --delete-mode <delete_when_no_subscriptions|delete_when_subscriptions_caught_up>` (cherry picked from commit db4dda4)
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…sarctl#444) Signed-off-by: Zixuan Liu <nodeces@gmail.com> ### Changes background from streamnative/pulsarctl#246, the PR implements the following commands: - `pulsarctl topics get-inactive-topic-policies <topic> --applied <bool>` - `pulsarctl topics remove-inactive-topic-policies <topic>` - `pulsarctl topics set-inactive-topic-policies <topic> --enable-delete-while-inactive <bool> --max-inactive-duration <string> --delete-mode <delete_when_no_subscriptions|delete_when_subscriptions_caught_up>`
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
…sarctl#444) Signed-off-by: Zixuan Liu <nodeces@gmail.com> ### Changes background from streamnative/pulsarctl#246, the PR implements the following commands: - `pulsarctl topics get-inactive-topic-policies <topic> --applied <bool>` - `pulsarctl topics remove-inactive-topic-policies <topic>` - `pulsarctl topics set-inactive-topic-policies <topic> --enable-delete-while-inactive <bool> --max-inactive-duration <string> --delete-mode <delete_when_no_subscriptions|delete_when_subscriptions_caught_up>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu nodeces@gmail.com
Changes
background from #246, the PR implements the following commands:
pulsarctl topics get-inactive-topic-policies <topic> --applied <bool>pulsarctl topics remove-inactive-topic-policies <topic>pulsarctl topics set-inactive-topic-policies <topic> --enable-delete-while-inactive <bool> --max-inactive-duration <string> --delete-mode <delete_when_no_subscriptions|delete_when_subscriptions_caught_up>