-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sink resource #38
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks fine.
Is there any guidance on how to actually run it?
@nlu90 Currently, we only have README.md, you can check out the |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Seems my local env lacks of some dependency.
Did you test the sink can be submitted correctly? |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nlu90 Good catch, |
|
ed9791d
to
013c3b5
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nlu90 I fix the above issues, you can use the following script to test this, make sure your workspace is clean: gh repo clone https://github.com/streamnative/terraform-provider-pulsar
cd terraform-provider-pulsar
gh pr checkout 38
make build-dev
cd examples/sinks/
terraform init
terraform apply |
Signed-off-by: Max Xu <huan.xu@streamnative.io>
Fix #37
TODO