Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sink resource #38

Merged
merged 16 commits into from
Jul 17, 2022
Merged

Add sink resource #38

merged 16 commits into from
Jul 17, 2022

Conversation

nodece
Copy link
Contributor

@nodece nodece commented Nov 4, 2021

Fix #37

TODO

  • Add description for sink resource
  • Update README.md

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@sijie sijie requested review from freeznet and nlu90 November 10, 2021 06:04
@sijie
Copy link
Member

sijie commented Nov 10, 2021

@nlu90 @freeznet Can you review this PR?

Copy link
Contributor

@nlu90 nlu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks fine.

Is there any guidance on how to actually run it?

@nodece
Copy link
Contributor Author

nodece commented Nov 11, 2021

@nlu90 Currently, we only have README.md, you can check out the Installation and Example sections. When you clone this PR to local, you need to run make build-dev to install this plugin to Terraform.

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nlu90
Copy link
Contributor

nlu90 commented Nov 11, 2021

Seems my local env lacks of some dependency.

│ Error: open testdata/pulsar-io/pulsar-io-jdbc-postgres-2.8.1.nar: no such file or directory
│
│   with pulsar_sink.sink-1,
│   on main.tf line 33, in resource "pulsar_sink" "sink-1":
│   33: resource "pulsar_sink" "sink-1" {
│
╵

Did you test the sink can be submitted correctly?

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece
Copy link
Contributor Author

nodece commented Nov 12, 2021

@nlu90 Good catch, pulsar-io-jdbc-postgres-2.8.1.nar has been added to examples.

@nlu90
Copy link
Contributor

nlu90 commented Nov 15, 2021

  1. I don't think we should commit the binary file pulsar-io-jdbc-postgres-2.8.1.nar into the repo. It's better to have some instructions on where to download it and how to set it up.

  2. I got the following issues when trying again by running terraform init:

╷
│ Error: Failed to install provider
│
│ Error while installing apache/pulsar v1.0.0: the local package for registry.terraform.io/apache/pulsar 1.0.0 doesn't match any of the checksums previously recorded in
│ the dependency lock file (this might be because the available checksums are for packages targeting different platforms)
╵

@nodece nodece force-pushed the sinks branch 3 times, most recently from ed9791d to 013c3b5 Compare November 16, 2021 02:48
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece
Copy link
Contributor Author

nodece commented Nov 16, 2021

@nlu90 I fix the above issues, you can use the following script to test this, make sure your workspace is clean:

gh repo clone https://github.com/streamnative/terraform-provider-pulsar
cd terraform-provider-pulsar
gh pr checkout 38
make build-dev
cd examples/sinks/
terraform init
terraform apply

@nodece nodece requested a review from nlu90 November 16, 2021 07:44
@nodece nodece requested a review from a team as a code owner July 17, 2022 12:01
Signed-off-by: Max Xu <huan.xu@streamnative.io>
@maxsxu maxsxu merged commit 5f32820 into streamnative:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sink support
4 participants