Refine playback #29
Refine playback #29
Conversation
| setTimeout(() => { | ||
| dispatch(fetchStream(streamId)) | ||
| dispatch(fetchStreamData(streamId)).then(resolve) | ||
| }, 1000) |
There was a problem hiding this comment.
This just makes the frontend retry until the upload to S3 is complete. In testing, it rarely retries more than once.
There was a problem hiding this comment.
I think that should be fine! As long as it really isn't a noticeable thing. What about if the upload fails for whatever reason? Should we worry about that?
There was a problem hiding this comment.
We should worry about that, but I don't think the frontend should.
| this.position = clamp(initialPosition + now - start, 0, this.duration) | ||
| this.emit('POSITION_CHANGE', this.position) | ||
|
|
||
| if (this._draw()) { |
There was a problem hiding this comment.
_draw() returns false when there's nothing left to draw (i.e., once the stream is done playing).
| } | ||
|
|
||
| return this.parsedLines[index] | ||
| } |
|
|
||
| setPosition (position) { | ||
| const wasPlaying = this.playing | ||
| if (this.playing) this.pause() |
There was a problem hiding this comment.
if (wasPlaying) this.pause()?
There was a problem hiding this comment.
That works too! Probably more descriptive. Thanks.
|
|
||
| EventEmitter(DrawManager.prototype) | ||
|
|
||
| /* global d3, requestAnimationFrame, cancelAnimationFrame */ |
There was a problem hiding this comment.
These comments tell the linter "ay, these are defined in the global scope, so don't get mad at me for referencing undefined variables"
This adds some enhancements to playback
Greg, I'm putting you in this PR, because you told me you haven't built the frontend in 2 months. ;)