Allow partition id as a parameter for publish command. #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow both partition key and partition id at the same time.
harbu
requested changes
Jun 25, 2024
| @@ -63,4 +73,5 @@ createClientCommand(async (client: StreamrClient, streamId: string, options: Opt | |||
| .arguments('<streamId>') | |||
| .description('publish to a stream by reading JSON messages from stdin line-by-line') | |||
| .option('-k, --partition-key-field <string>', 'field name in each message to use for assigning the message to a stream partition') | |||
| .option('-p, --partition [partition]', 'partition') | |||
There was a problem hiding this comment.
Move the use of createFnParseInthere. See streamr-stream-subscribe.ts for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not allow both partition key and partition id at the same time.
Summary
Added partition id as possible parameter for publish command.
Changes
We'll check if partition key and id are given as parameters and give suitable error msg. It's one or the other but not both as parameter options.
Limitations and future improvements
Provide a bullet list or description of known omissions or limitations of the
solution and/or any ideas for future improvement. Leave section ouf if
not applicable.
Checklist before requesting a review
TODOcomments left behind are meant to be left in.