Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(runtime): fix breaking change due to random container id
- Loading branch information
1 parent
689a9e3
commit b390c62
Showing
5 changed files
with
152 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
azkarra-runtime/src/main/java/io/streamthoughts/azkarra/runtime/env/ContainerIdBuilder.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Copyright 2021 StreamThoughts. | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.streamthoughts.azkarra.runtime.env; | ||
|
|
||
| import io.streamthoughts.azkarra.api.ApplicationId; | ||
| import io.streamthoughts.azkarra.api.ContainerId; | ||
| import io.streamthoughts.azkarra.api.config.Conf; | ||
| import io.streamthoughts.azkarra.api.streams.KafkaStreamsContainer; | ||
| import io.streamthoughts.azkarra.api.streams.topology.TopologyMetadata; | ||
|
|
||
| /** | ||
| * A {@code ContainerIdBuilder} is used to build {@link ContainerId}. | ||
| */ | ||
| public interface ContainerIdBuilder { | ||
|
|
||
| /** | ||
| * Builds the identifier that will be used for identifying the {@link KafkaStreamsContainer} running the topology. | ||
| * | ||
| * @param metadata the topology's metadata. | ||
| * @param config the topology's configuration. | ||
| * | ||
| * @return a new {@link ContainerId} instance. | ||
| */ | ||
| ContainerId buildContainerId(final ApplicationId applicationId, | ||
| final TopologyMetadata metadata, | ||
| final Conf config); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...c/main/java/io/streamthoughts/azkarra/runtime/env/internal/DefaultContainerIdBuilder.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Copyright 2021 StreamThoughts. | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.streamthoughts.azkarra.runtime.env.internal; | ||
|
|
||
| import io.streamthoughts.azkarra.api.ApplicationId; | ||
| import io.streamthoughts.azkarra.api.ContainerId; | ||
| import io.streamthoughts.azkarra.api.config.Conf; | ||
| import io.streamthoughts.azkarra.api.streams.topology.TopologyMetadata; | ||
| import io.streamthoughts.azkarra.runtime.env.ContainerIdBuilder; | ||
|
|
||
| public class DefaultContainerIdBuilder implements ContainerIdBuilder { | ||
|
|
||
| public static final String CONTAINER_ID_CONFIG = "container.id"; | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public ContainerId buildContainerId(final ApplicationId applicationId, | ||
| final TopologyMetadata metadata, | ||
| final Conf config) { | ||
| if (config.hasPath(CONTAINER_ID_CONFIG)) | ||
| return new BasicContainerId(config.getString(CONTAINER_ID_CONFIG)); | ||
|
|
||
| return BasicContainerId.create(applicationId); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters