-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construction quest now has an option "exact date is known" fixes #1341 #2402
Conversation
…etcomplete#1341 available via can't say menu, a bit hidden but as discussed in streetcomplete#1341 it is hard to find a better place for it
...main/java/de/westnordost/streetcomplete/quests/construction/MarkCompletedConstructionForm.kt
Outdated
Show resolved
Hide resolved
...n/java/de/westnordost/streetcomplete/quests/construction/MarkCompletedHighwayConstruction.kt
Outdated
Show resolved
Hide resolved
.../java/de/westnordost/streetcomplete/quests/construction/MarkCompletedBuildingConstruction.kt
Outdated
Show resolved
Hide resolved
...n/java/de/westnordost/streetcomplete/quests/construction/MarkCompletedHighwayConstruction.kt
Outdated
Show resolved
Hide resolved
You chose the "open"-wording. However, this may apply to roads and businesses, but you wouldn't be able to say that a "apartment building is open". |
OK, so I need to change it back. I basically learned about one more difference between Polish and English. |
"apartment building is open" sounds to me like maybe it is "open" in the sense of that the roof is missing and thus at the top, it's open. ;-) In German, you can say that a thing is "eröffnet" (=opened), but you can only say that for something public because it suggests that it is open for people to enter/use, i.e. also not for apartments. |
Looks good now! Did you test it? |
I changed again to "Will be finished at date…" to make clear that it is not about recording completion date that already happened. I tested it, though I am running right now retest after all this text changes. |
Still works, as expected. |
available via can't say menu, a bit hidden but as discussed in #1341
it is hard to find a better place for it