Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v32.0-alpha2] Don't show the quest reorder handle icon for the note quest #2887

Closed
cyclingcat opened this issue May 17, 2021 · 4 comments
Closed
Assignees

Comments

@cyclingcat
Copy link

Hi there,

issue #2828 introduced the quest reorder handle icon in order to give the user a hint that the quest order can be changed. However, this icon is currently also shown for the note quest which cannot be moved away from the first position. I guess it would make sense not to show this icon for this entry:

quest_reorder

BTW: Are the "technical reasons" mentioned in #1815 (comment) and #1815 (comment) still valid considering the new architecture of v32 or could the note quest be treated like any other quest now, with the ability to be reordered and disabled?

The cycling cat

@cyclingcat cyclingcat added the bug label May 17, 2021
@westnordost westnordost removed the bug label May 17, 2021
@westnordost
Copy link
Member

Yes, still valid. Quests should not be shown when there is a note. This is not an "architectural issue" but a feature.

@cyclingcat
Copy link
Author

Okay. But the handle of this entry should be removed, shouldn't it?

The cycling cat

@matkoniecz
Copy link
Member

Pinging @FloEdelmann - author of #2843 (hopefully it is OK)

@FloEdelmann
Copy link
Member

I already reacted to #2887 (comment) with a 👍 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants