Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that quest selection screen allows reordering #2843

Merged
merged 4 commits into from May 4, 2021
Merged

Clarify that quest selection screen allows reordering #2843

merged 4 commits into from May 4, 2021

Conversation

FloEdelmann
Copy link
Member

Closes #2828.

  • Rename screen from "Quest selection" to "Quest selection and priority". I avoided the word "order", as "priority" is already used in that screen and I think it's better to stick with one word for one concept.

  • Add a drag handle at the left of each quest selection row. Dragging there is immediately possible (without long-press), dragging anywhere by long-pressing is still allowed.

I used the drag-vertical Material Design Icon, should I add that to authors.txt?

@westnordost
Copy link
Member

Nice, also looks more slim than I thought! Though, regarding the size, according to the accessibility guidelines, the minimum size for a tap area should be about 40dp (ideally 48dp), see

https://material.io/design/usability/accessibility.html#layout-and-typography

If this is becoming too wide, one possibility to have it visually still small, but the invisible click area overlaps with the icon.

@westnordost
Copy link
Member

avoided the word "order", as "priority" is already used in that screen and I think it's better to stick with one word for one concept.

👍

@FloEdelmann
Copy link
Member Author

I've made the touch area bigger, so it's now 48dp wide (and still fills the available height):

grafik

@westnordost
Copy link
Member

Nice, thanks!

@westnordost westnordost merged commit 76b2b7d into streetcomplete:master May 4, 2021
@FloEdelmann FloEdelmann deleted the drag-handle branch May 4, 2021 14:49
@matkoniecz
Copy link
Member

I used the drag-vertical Material Design Icon, should I add that to authors.txt?

It may be overkill, at that point such work is no longer eligible for copyright anyway. But adding would be still OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a re-order handle icon to the quests list to hint that it is user sortable
3 participants