Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translators credits are truncated to just 8 languages #628

Closed
antonv6 opened this issue Oct 3, 2017 · 9 comments
Closed

Translators credits are truncated to just 8 languages #628

antonv6 opened this issue Oct 3, 2017 · 9 comments
Assignees
Labels

Comments

@antonv6
Copy link
Contributor

antonv6 commented Oct 3, 2017

In 2.1, credits screen only shows translators for these languages: Català, Dansk, Deutsch, English, Español, Euskara, Français and Italiano, in this order. So, only 8 languages out of 24 supported are shown.

@westnordost
Copy link
Member

westnordost commented Oct 3, 2017

Hm I can't reproduce this. Which Android version are you using? Is the "See the project on POEditor for a complete list" shown at the bottom?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 3, 2017
@antonv6
Copy link
Contributor Author

antonv6 commented Oct 3, 2017

I'm on plain android 6.0.1. I've switched to various system languages, but still could only see these 8 items.

For the record, I see the link, but #629.

@antonv6
Copy link
Contributor Author

antonv6 commented Oct 3, 2017

Oh, I've found something: I can see the full list in horizontal mode, but not in vertical.

@westnordost
Copy link
Member

Hm, I can see it in portrait and landscape either way.

@westnordost
Copy link
Member

Can you independently scroll the area in which the language credits are shown?

@westnordost westnordost added the bug label Oct 3, 2017
@antonv6
Copy link
Contributor Author

antonv6 commented Oct 3, 2017

I can, using two fingers: sort of like one is holding the whole screen to prevent it from scrolling, and then the other finger scrolls the credits.

@rugk
Copy link
Contributor

rugk commented Oct 3, 2017

Indeed that works. I can reproduce the issue. v2.0 on LineageOS 14 (Android 7).

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 3, 2017
@westnordost westnordost self-assigned this Oct 3, 2017
@westnordost
Copy link
Member

Okay, so that seems to be the issue. I couldn't reproduce it though, and I did not find any hints how to fix this issue, so I ditched the RecyclerView layout and instead used a normal LinearLayout (it's also easier-to-read-code this way).

Does anyone of you two build from source? Then you could check if this fixed the issue.

@Binnette
Copy link
Contributor

Binnette commented Oct 4, 2017

@westnordost
I can reproduce the error before a838a36 and can not after. So I confirm that this bug is fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants