Extract quest data models #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
changed the title
BikeParkingType data model
westnordost
reviewed
Jan 14, 2021
app/src/main/java/de/westnordost/streetcomplete/quests/kerb_height/KerbHeight.kt
Show resolved
Hide resolved
| // sorted by ~worldwide usages, minus country specific ones | ||
| MULTI("multi"), | ||
|
|
||
| // 250k - 10k |
There was a problem hiding this comment.
the comments about the usage numbers should actually go to the quest form, because this is where the order matters. The order does not matter in an enum (read: should not)
There was a problem hiding this comment.
But I can just do that after the merge
There was a problem hiding this comment.
In the quest form, the list is sorted by country usage anyway, so order there shouldn't matter either.
|
🚀 |
|
So, all fine, I'll merge it. Thank you for your work! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2495. Fixes second part and closes #2494.