Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract remaining quest data models #2511

Merged
merged 8 commits into from
Jan 17, 2021
Merged

Extract remaining quest data models #2511

merged 8 commits into from
Jan 17, 2021

Conversation

FloEdelmann
Copy link
Member

Follow-up to #2501. References #2494.

Now the only quests extending OsmFilterQuestType<String> are those with a free-text input field (with suggestions), namely AddAtmOperator and AddChargingStationOperator.

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice work! I didn't realize there were so many quests who do not use the image picker that were still string-based.

@westnordost westnordost merged commit 3d6cb94 into streetcomplete:master Jan 17, 2021
@FloEdelmann FloEdelmann deleted the extract-data-models branch January 17, 2021 15:43
@westnordost westnordost mentioned this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants