Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also ask for other venues which might have food #3431

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

peternewman
Copy link
Collaborator

@peternewman peternewman commented Oct 23, 2021

But only if it's tagged that they do

Untested but trivial.

But only if it's tagged that they do
But only if it's tagged that they do
@peternewman
Copy link
Collaborator Author

Off the back of @10992-osm 's comment #3408 (comment) .

I haven't touched the Halal or Kosher quests, but it looks like we could add them to the latter but not the former:
https://www.foodnavigator-asia.com/Article/2019/07/29/Zero-halal-Heineken-clarifies-its-zero-alcohol-beer-is-for-non-Muslims-only
https://www.dummies.com/food-drink/drinks/beer/choosing-a-kosher-beer

@westnordost
Copy link
Member

ok

@rugk
Copy link
Contributor

rugk commented Oct 23, 2021

Given the same likely would make sense for (future) halal quest etc. (in addition to vegetarian/vegan quests), could there be some abstraction/common reference for "all venues which sell food" - which you can then use in each of these quests?

@westnordost westnordost merged commit 5672572 into streetcomplete:master Oct 24, 2021
@FloEdelmann FloEdelmann added the hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event label Oct 24, 2021
@peternewman
Copy link
Collaborator Author

Given the same likely would make sense for (future) halal quest etc. (in addition to vegetarian/vegan quests), could there be some abstraction/common reference for "all venues which sell food" - which you can then use in each of these quests?

Possibly in general @rugk , but e.g. 99% of ice cream is vegetarian, but "normal" ice cream isn't vegan so there's a different set of categories there. Likewise some places might not exist for Halal (the quest exists BTW) or Kosher reasons, but there may be vegan/vegetarian versions.

@matkoniecz
Copy link
Member

matkoniecz commented Oct 24, 2021

For example shop=butcher is valid for halal/kosher but asking it for vegan/vegetarian is likely not useful :)

EDIT: though some may actually sell also vegetarian products! Still, not useful to ask that (at least nowadays - it may change!).

@peternewman
Copy link
Collaborator Author

For example shop=butcher is valid for halal/kosher but asking it for vegan/vegetarian is likely not useful :)

They might sell vegan sausages too... 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants